Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71653003: ash: Rename LauncherModel to ShelfModel. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

ash: Rename LauncherModel to ShelfModel. * Move launcher_model.* from launcher/ to shelf/ * Rename to shelf_model.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235217

Patch Set 1 #

Patch Set 2 : renames #

Patch Set 3 : more renames #

Patch Set 4 : ash_unittests links #

Patch Set 5 : chrome changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -991 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/launcher/launcher.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M ash/launcher/launcher_item_delegate_manager.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/launcher/launcher_item_delegate_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
D ash/launcher/launcher_model.h View 1 chunk +0 lines, -91 lines 0 comments Download
D ash/launcher/launcher_model.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D ash/launcher/launcher_model_unittest.cc View 1 chunk +0 lines, -405 lines 0 comments Download
M ash/launcher/launcher_unittest.cc View 1 2 3 10 chunks +14 lines, -15 lines 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/overflow_bubble.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shelf/overflow_button.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + ash/shelf/shelf_model.h View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
A + ash/shelf/shelf_model.cc View 1 2 8 chunks +15 lines, -16 lines 0 comments Download
M ash/shelf/shelf_model_observer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ash/shelf/shelf_model_unittest.cc View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
M ash/shelf/shelf_model_util.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_model_util.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_navigator.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_navigator.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 2 3 12 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 8 chunks +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/window_watcher.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shell_delegate.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M ash/shell_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/shelf_view_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/shell_test_api.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_launcher_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/test/test_launcher_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 4 21 chunks +83 lines, -90 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
I said it would be big ;) :/ Please, take a look. Thanks,
7 years, 1 month ago (2013-11-14 02:31:36 UTC) #1
James Cook
lgtm
7 years, 1 month ago (2013-11-14 16:50:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/71653003/110001
7 years, 1 month ago (2013-11-14 17:47:24 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 19:48:40 UTC) #4
Message was sent while issue was closed. 
Change committed as 235217

Powered by Google App Engine
This is Rietveld 408576698