Use "int" rather than "long" for C++ code interacting with WebIDL's "long".

Use "int" rather than "long" for C++ code interacting with WebIDL's "long".

(WebIDL's "long" is a 32-bit type)

BUG=267360
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185331

[eroman, 2014-11-13 01:25:16]

eroman@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2014-11-13 12:15:26]

lgtm % one request

https://codereview.chromium.org/716323002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/RTCDataChannel.h (right):

https://codereview.chromium.org/716323002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/RTCDataChannel.h:69: unsigned bufferedAmount() const;
unsigned int?

[eroman, 2014-11-13 19:18:07]

https://codereview.chromium.org/716323002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/RTCDataChannel.h (right):

https://codereview.chromium.org/716323002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/RTCDataChannel.h:69: unsigned bufferedAmount() const;
On 2014/11/13 12:15:26, tommi wrote:
> unsigned int?

While I personally agree with you, the style in Blink seems to be to use
"unsigned" rather than "unsigned int".

That is the dominant usage, and I have gotten feedback to use that from other
reviewers.

[tommi (sloooow) - chröme, 2014-11-13 21:07:44]

Ah, right. Nevermind, Lgtm stands

On Thu, Nov 13, 2014, 20:18 null <eroman@chromium.org> wrote:

>
> https://codereview.chromium.org/716323002/diff/20001/
> Source/modules/mediastream/RTCDataChannel.h
> File Source/modules/mediastream/RTCDataChannel.h (right):
>
> https://codereview.chromium.org/716323002/diff/20001/
> Source/modules/mediastream/RTCDataChannel.h#newcode69
> Source/modules/mediastream/RTCDataChannel.h:69
>
<https://codereview.chromium.org/716323002/diff/20001/Source/modules/mediastre...>:
> unsigned
> bufferedAmount() const;
> On 2014/11/13 12:15:26, tommi wrote:
> > unsigned int?
>
> While I personally agree with you, the style in Blink seems to be to use
> "unsigned" rather than "unsigned int".
>
> That is the dominant usage, and I have gotten feedback to use that from
> other reviewers.
>
> https://codereview.chromium.org/716323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[tommi (sloooow) - chröme, 2014-11-13 22:18:08]

lgtm

[eroman, 2014-11-13 22:19:34]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-11-13 22:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716323002/20001

[commit-bot: I haz the power, 2014-11-14 00:09:06]

Committed patchset #2 (id:20001) as 185331