Source/modules/mediastream/RTCDataChannel.h - Issue 716323002: Use "int" rather than "long" for C++ code interacting with WebIDL's "long".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/RTCDataChannel.h

Issue 716323002: Use "int" rather than "long" for C++ code interacting with WebIDL's "long". (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/mediastream/RTCDataChannel.h

diff --git a/Source/modules/mediastream/RTCDataChannel.h b/Source/modules/mediastream/RTCDataChannel.h

index 37004db8189f2161308ecf432b6ee32ae344e8d5..85c8afd950ff35bab2fff12a6f12ad246713cfad 100644

--- a/Source/modules/mediastream/RTCDataChannel.h

+++ b/Source/modules/mediastream/RTCDataChannel.h

@@ -66,7 +66,7 @@ public:

bool negotiated() const;

unsigned short id() const;

String readyState() const;

- unsigned long bufferedAmount() const;

+ unsigned bufferedAmount() const;

tommi (sloooow) - chröme 2014/11/13 12:15:26 unsigned int?

eroman 2014/11/13 19:18:07 While I personally agree with you, the style in Bl

String binaryType() const;

void setBinaryType(const String&, ExceptionState&);

« no previous file with comments | « Source/modules/mediastream/RTCDTMFSender.cpp ('k') | Source/modules/mediastream/RTCDataChannel.cpp » ('j') | no next file with comments »