Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: Source/modules/mediastream/RTCDTMFSender.cpp

Issue 716323002: Use "int" rather than "long" for C++ code interacting with WebIDL's "long". (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCDTMFSender.cpp
diff --git a/Source/modules/mediastream/RTCDTMFSender.cpp b/Source/modules/mediastream/RTCDTMFSender.cpp
index 110e240f70d0e0894cec4ab5ae339daee6ef4b15..d3cfad18808160d992c9ae7706e990effc0c4e70 100644
--- a/Source/modules/mediastream/RTCDTMFSender.cpp
+++ b/Source/modules/mediastream/RTCDTMFSender.cpp
@@ -38,11 +38,11 @@
namespace blink {
-static const long minToneDurationMs = 70;
-static const long defaultToneDurationMs = 100;
-static const long maxToneDurationMs = 6000;
-static const long minInterToneGapMs = 50;
-static const long defaultInterToneGapMs = 50;
+static const int minToneDurationMs = 70;
+static const int defaultToneDurationMs = 100;
+static const int maxToneDurationMs = 6000;
+static const int minInterToneGapMs = 50;
+static const int defaultInterToneGapMs = 50;
RTCDTMFSender* RTCDTMFSender::create(ExecutionContext* context, WebRTCPeerConnectionHandler* peerConnectionHandler, MediaStreamTrack* track, ExceptionState& exceptionState)
{
@@ -93,12 +93,12 @@ void RTCDTMFSender::insertDTMF(const String& tones, ExceptionState& exceptionSta
insertDTMF(tones, defaultToneDurationMs, defaultInterToneGapMs, exceptionState);
}
-void RTCDTMFSender::insertDTMF(const String& tones, long duration, ExceptionState& exceptionState)
+void RTCDTMFSender::insertDTMF(const String& tones, int duration, ExceptionState& exceptionState)
{
insertDTMF(tones, duration, defaultInterToneGapMs, exceptionState);
}
-void RTCDTMFSender::insertDTMF(const String& tones, long duration, long interToneGap, ExceptionState& exceptionState)
+void RTCDTMFSender::insertDTMF(const String& tones, int duration, int interToneGap, ExceptionState& exceptionState)
{
if (!canInsertDTMF()) {
exceptionState.throwDOMException(NotSupportedError, "The 'canInsertDTMF' attribute is false: this sender cannot send DTMF.");

Powered by Google App Engine
This is Rietveld 408576698