Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 715903002: Push creation of default GP to the caller (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Push creation of default GP to the caller TBR= BUG=skia: Committed: https://skia.googlesource.com/skia/+/5478d427c6e67c986a3390162c8fec77c466058a

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -225 lines) Patch
M gm/convexpolyeffect.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 4 chunks +5 lines, -11 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 4 chunks +16 lines, -13 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 6 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 7 chunks +21 lines, -45 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 2 3 1 chunk +10 lines, -3 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 7 chunks +41 lines, -29 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 chunks +2 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 chunks +0 lines, -54 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 5 chunks +7 lines, -16 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 8 chunks +45 lines, -23 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
This is just a baby step in the right direction
6 years, 1 month ago (2014-11-11 21:36:45 UTC) #2
bsalomon
https://codereview.chromium.org/715903002/diff/20001/src/gpu/GrDefaultGeoProcFactory.h File src/gpu/GrDefaultGeoProcFactory.h (right): https://codereview.chromium.org/715903002/diff/20001/src/gpu/GrDefaultGeoProcFactory.h#newcode79 src/gpu/GrDefaultGeoProcFactory.h:79: static void SetAttribs(GrDrawState*, uint32_t GPTypeFlags = 0); Can we ...
6 years, 1 month ago (2014-11-13 14:39:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715903002/60001
6 years, 1 month ago (2014-11-14 23:52:55 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 00:00:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5478d427c6e67c986a3390162c8fec77c466058a

Powered by Google App Engine
This is Rietveld 408576698