Chromium Code Reviews Chromium Code Reviews
Issue 715903002:
Push creation of default GP to the caller (Closed)
Base URL: https://skia.googlesource.com/skia.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright 2014 Google Inc. | 2 * Copyright 2014 Google Inc. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license that can be | 4 * Use of this source code is governed by a BSD-style license that can be |
| 5 * found in the LICENSE file. | 5 * found in the LICENSE file. |
| 6 */ | 6 */ |
| 7 | 7 |
| 8 #ifndef GrDefaultGeoProcFactory_DEFINED | 8 #ifndef GrDefaultGeoProcFactory_DEFINED |
| 9 #define GrDefaultGeoProcFactory_DEFINED | 9 #define GrDefaultGeoProcFactory_DEFINED |
| 10 | 10 |
| (...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 69 | 69 |
| 70 enum GPType { | 70 enum GPType { |
| 71 kPosition_GPType = 0x0, // we ALWAYS have position | 71 kPosition_GPType = 0x0, // we ALWAYS have position |
| 72 kColor_GPType = 0x01, | 72 kColor_GPType = 0x01, |
| 73 kLocalCoord_GPType = 0x02, | 73 kLocalCoord_GPType = 0x02, |
| 74 kCoverage_GPType= 0x04, | 74 kCoverage_GPType= 0x04, |
| 75 kLastGPType = kCoverage_GPType | 75 kLastGPType = kCoverage_GPType |
| 76 }; | 76 }; |
| 77 | 77 |
| 78 // YOU MUST UNREF | 78 // YOU MUST UNREF |
| 79 static const GrGeometryProcessor* CreateAndSetAttribs(GrDrawState*, uint32_t GPTypeFlags); | 79 static void SetAttribs(GrDrawState*, uint32_t GPTypeFlags = 0); |
|
bsalomon
2014/11/13 14:39:21
Can we have some more detailed comments here about
| |
| 80 static const GrGeometryProcessor* Create(); | 80 static const GrGeometryProcessor* CreateAndSetAttribs(GrDrawState*, uint32_t GPTypeFlags = 0); |
| 81 static const GrGeometryProcessor* Create(bool hasAttributeCoverage); | |
| 81 }; | 82 }; |
| 82 | 83 |
| 83 #endif | 84 #endif |
| OLD | NEW |
