Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: src/gpu/GrDrawTarget.h

Issue 715903002: Push creation of default GP to the caller (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: added comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrDefaultPathRenderer.cpp ('k') | src/gpu/GrDrawTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawTarget.h
diff --git a/src/gpu/GrDrawTarget.h b/src/gpu/GrDrawTarget.h
index 41f9b366fca68fb1e4ef9a16470b500de8754621..75a2f258f29416d068ac68ef93c3d85233107a30 100644
--- a/src/gpu/GrDrawTarget.h
+++ b/src/gpu/GrDrawTarget.h
@@ -808,10 +808,6 @@ protected:
GrContext* getContext() { return fContext; }
const GrContext* getContext() const { return fContext; }
- // A subclass may override this function if it wishes to be notified when the clip is changed.
- // The override should call INHERITED::clipWillBeSet().
- virtual void clipWillBeSet(const GrClipData* clipData);
-
// subclasses must call this in their destructors to ensure all vertex
// and index sources have been released (including those held by
// pushGeometrySource())
@@ -855,15 +851,10 @@ private:
virtual void geometrySourceWillPop(const GeometrySrcState& restoredState) = 0;
// subclass called to perform drawing
virtual void onDraw(const DrawInfo&, const GrClipMaskManager::ScissorState&) = 0;
- // Implementation of drawRect. The geometry src and vertex attribs will already
- // be saved before this is called and restored afterwards. A subclass may override
- // this to perform more optimal rect rendering. Its draws should be funneled through
- // one of the public GrDrawTarget draw methods (e.g. drawNonIndexed,
- // drawIndexedInstances, ...). The base class draws a two triangle fan using
- // drawNonIndexed from reserved vertex space.
+ // TODO copy in order drawbuffer onDrawRect to here
virtual void onDrawRect(const SkRect& rect,
const SkRect* localRect,
- const SkMatrix* localMatrix);
+ const SkMatrix* localMatrix) = 0;
virtual void onStencilPath(const GrPath*,
const GrClipMaskManager::ScissorState&,
« no previous file with comments | « src/gpu/GrDefaultPathRenderer.cpp ('k') | src/gpu/GrDrawTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698