Issue 715163002: Add headers to gn/gni files for all of sky/engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715163002: Add headers to gn/gni files for all of sky/engine (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, jamesr, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Add headers to gn/gni files for all of sky/engine Also sorted the sources. This stops sky/tools/missing_from_gn from complaining about our headers being missing. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/59e8dc95a0200114706e47b1d8a66d15b7473e11

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+839 lines, -465 lines)			Patch
M	sky/engine/BUILD.gn	View	1 chunk	+5 lines, -24 lines	0 comments	Download
M	sky/engine/core/core.gni	View	41 chunks	+438 lines, -239 lines	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	20 chunks	+171 lines, -149 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+154 lines, -0 lines	0 comments	Download
M	sky/engine/wtf/BUILD.gn	View	8 chunks	+68 lines, -51 lines	0 comments	Download
M	sky/tools/missing_from_gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/viewer/cc/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

eseidel

This is sorta a silly patch, but it does bring us closer to a world ...

6 years, 1 month ago (2014-11-12 01:00:56 UTC) #1

jamesr

Adding header files to GN is important - 'gn check' ignores files (including headers) it ...

6 years, 1 month ago (2014-11-12 01:01:56 UTC) #2

eseidel

6 years, 1 month ago (2014-11-12 19:36:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
59e8dc95a0200114706e47b1d8a66d15b7473e11 (presubmit successful).