Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: sky/tools/missing_from_gn

Issue 715163002: Add headers to gn/gni files for all of sky/engine (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/wtf/BUILD.gn ('k') | sky/viewer/cc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/missing_from_gn
diff --git a/sky/tools/missing_from_gn b/sky/tools/missing_from_gn
index fdc64d07e99c64ed77d8a96a28bb89a73d73b8f7..88ecee6894a322157cc982ed0a606f602def6a0e 100755
--- a/sky/tools/missing_from_gn
+++ b/sky/tools/missing_from_gn
@@ -45,7 +45,8 @@ def used_files(target):
def find_on_disk(path):
# FIXME: Use os.walk and do fancier ignoring.
- return stripped_lines_from_command(['find', path, '-type', 'f'])
+ find_cmd = ['find', path, '-type', 'f']
+ return stripped_lines_from_command(find_cmd, cwd=ROOT_DIR)
def main():
@@ -72,7 +73,6 @@ def main():
'.gypi',
'.gn',
'.gni',
- '.h', # Ignore headers for the moment.
]
for ext in IGNORED_EXTENSIONS:
missing_from_gn = filter(lambda p: not p.endswith(ext), missing_from_gn)
« no previous file with comments | « sky/engine/wtf/BUILD.gn ('k') | sky/viewer/cc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698