Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: sky/engine/BUILD.gn

Issue 715163002: Add headers to gn/gni files for all of sky/engine (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/BUILD.gn
diff --git a/sky/engine/BUILD.gn b/sky/engine/BUILD.gn
index 4f8f0bec66464752ac2fb13b0310b8dd61cb5044..33eb367ec107693e7cc4bb4c72e78c83082b991a 100644
--- a/sky/engine/BUILD.gn
+++ b/sky/engine/BUILD.gn
@@ -38,31 +38,12 @@ config("config") {
cflags = []
defines = []
- if (is_win) {
- cflags += [
- "/wd4065", # Switch statement contains 'default' but no 'case' labels.
- # In generated parser code.
- "/wd4305", # Truncation from 'type1' to 'type2'.
- "/wd4324", # Struct padded due to declspec(align).
- "/wd4702", # Unreachable code, happens in bison-generated code.
- "/wd4714", # Function marked forceinline not inlined.
- "/wd4800", # Value forced to bool.
- "/wd4996", # Deprecated function call.
- ]
- }
-
- if (is_win) {
- if (component_mode == "shared_library") {
- defines += [ "USING_V8_SHARED" ]
- }
- } else { # ! Windows
- # TODO(GYP) this should be based on gcc_version >= 46 but GN doesn't have a
- # concept of GCC version yet.
+ # TODO(GYP) this should be based on gcc_version >= 46 but GN doesn't have a
+ # concept of GCC version yet.
- # Disable warnings about c++0x compatibility, as some names (such as
- # nullptr) conflict with upcoming c++0x types.
- cflags_cc = [ "-Wno-c++0x-compat" ]
- }
+ # Disable warnings about c++0x compatibility, as some names (such as
+ # nullptr) conflict with upcoming c++0x types.
+ cflags_cc = [ "-Wno-c++0x-compat" ]
if (is_linux && cpu_arch == "arm") {
# Due to a bug in gcc arm, we get warnings about uninitialized
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698