Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 714663002: Fix has_constant_parameter_count() confusion in LReturn (Closed)

Created:
6 years, 1 month ago by Jakob Kummerow
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix has_constant_parameter_count() confusion in LReturn BUG=chromium:431602 LOG=y R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-431602.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
PTAL.
6 years, 1 month ago (2014-11-10 15:09:40 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-10 15:15:25 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-11-10 15:25:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25249 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698