Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 714663002: Fix has_constant_parameter_count() confusion in LReturn (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/double.h" 8 #include "src/double.h"
9 #include "src/factory.h" 9 #include "src/factory.h"
10 #include "src/hydrogen-infer-representation.h" 10 #include "src/hydrogen-infer-representation.h"
(...skipping 2816 matching lines...) Expand 10 before | Expand all | Expand 10 after
2827 r = Representation::Tagged(); 2827 r = Representation::Tagged();
2828 } 2828 }
2829 } 2829 }
2830 if (r.IsSmi()) { 2830 if (r.IsSmi()) {
2831 // If we have an existing handle, zap it, because it might be a heap 2831 // If we have an existing handle, zap it, because it might be a heap
2832 // number which we must not re-use when copying this HConstant to 2832 // number which we must not re-use when copying this HConstant to
2833 // Tagged representation later, because having Smi representation now 2833 // Tagged representation later, because having Smi representation now
2834 // could cause heap object checks not to get emitted. 2834 // could cause heap object checks not to get emitted.
2835 object_ = Unique<Object>(Handle<Object>::null()); 2835 object_ = Unique<Object>(Handle<Object>::null());
2836 } 2836 }
2837 if (r.IsSmiOrInteger32()) {
2838 // If it's not a heap object, it can't be in new space.
2839 bit_field_ = IsNotInNewSpaceField::update(bit_field_, true);
2840 }
2837 set_representation(r); 2841 set_representation(r);
2838 SetFlag(kUseGVN); 2842 SetFlag(kUseGVN);
2839 } 2843 }
2840 2844
2841 2845
2842 bool HConstant::ImmortalImmovable() const { 2846 bool HConstant::ImmortalImmovable() const {
2843 if (HasInteger32Value()) { 2847 if (HasInteger32Value()) {
2844 return false; 2848 return false;
2845 } 2849 }
2846 if (HasDoubleValue()) { 2850 if (HasDoubleValue()) {
(...skipping 1942 matching lines...) Expand 10 before | Expand all | Expand 10 after
4789 break; 4793 break;
4790 case HObjectAccess::kExternalMemory: 4794 case HObjectAccess::kExternalMemory:
4791 os << "[external-memory]"; 4795 os << "[external-memory]";
4792 break; 4796 break;
4793 } 4797 }
4794 4798
4795 return os << "@" << access.offset(); 4799 return os << "@" << access.offset();
4796 } 4800 }
4797 4801
4798 } } // namespace v8::internal 4802 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698