Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: src/mips64/lithium-codegen-mips64.cc

Issue 714663002: Fix has_constant_parameter_count() confusion in LReturn (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 2810 matching lines...) Expand 10 before | Expand all | Expand 10 after
2821 no_frame_start = masm_->pc_offset(); 2821 no_frame_start = masm_->pc_offset();
2822 __ Pop(ra, fp); 2822 __ Pop(ra, fp);
2823 } 2823 }
2824 if (instr->has_constant_parameter_count()) { 2824 if (instr->has_constant_parameter_count()) {
2825 int parameter_count = ToInteger32(instr->constant_parameter_count()); 2825 int parameter_count = ToInteger32(instr->constant_parameter_count());
2826 int32_t sp_delta = (parameter_count + 1) * kPointerSize; 2826 int32_t sp_delta = (parameter_count + 1) * kPointerSize;
2827 if (sp_delta != 0) { 2827 if (sp_delta != 0) {
2828 __ Daddu(sp, sp, Operand(sp_delta)); 2828 __ Daddu(sp, sp, Operand(sp_delta));
2829 } 2829 }
2830 } else { 2830 } else {
2831 DCHECK(info()->IsStub()); // Functions would need to drop one more value.
2831 Register reg = ToRegister(instr->parameter_count()); 2832 Register reg = ToRegister(instr->parameter_count());
2832 // The argument count parameter is a smi 2833 // The argument count parameter is a smi
2833 __ SmiUntag(reg); 2834 __ SmiUntag(reg);
2834 __ dsll(at, reg, kPointerSizeLog2); 2835 __ dsll(at, reg, kPointerSizeLog2);
2835 __ Daddu(sp, sp, at); 2836 __ Daddu(sp, sp, at);
2836 } 2837 }
2837 2838
2838 __ Jump(ra); 2839 __ Jump(ra);
2839 2840
2840 if (no_frame_start != -1) { 2841 if (no_frame_start != -1) {
(...skipping 3116 matching lines...) Expand 10 before | Expand all | Expand 10 after
5957 __ li(at, scope_info); 5958 __ li(at, scope_info);
5958 __ Push(at, ToRegister(instr->function())); 5959 __ Push(at, ToRegister(instr->function()));
5959 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5960 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5960 RecordSafepoint(Safepoint::kNoLazyDeopt); 5961 RecordSafepoint(Safepoint::kNoLazyDeopt);
5961 } 5962 }
5962 5963
5963 5964
5964 #undef __ 5965 #undef __
5965 5966
5966 } } // namespace v8::internal 5967 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698