Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 714303003: Move painting code from RenderPart to PartPainter. (Closed)

Created:
6 years, 1 month ago by chrishtr
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderPart to PartPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185241

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -84 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/core/paint/PartPainter.h View 1 chunk +8 lines, -7 lines 2 comments Download
A Source/core/paint/PartPainter.cpp View 1 chunk +97 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderPart.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderPart.cpp View 2 chunks +3 lines, -74 lines 0 comments Download
M Source/core/rendering/RenderReplaced.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrishtr
6 years, 1 month ago (2014-11-12 06:12:37 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/714303003/diff/1/Source/core/paint/PartPainter.h File Source/core/paint/PartPainter.h (left): https://codereview.chromium.org/714303003/diff/1/Source/core/paint/PartPainter.h#oldcode5 Source/core/paint/PartPainter.h:5: #ifndef SVGRootPainter_h I think we got outsmarted by (the ...
6 years, 1 month ago (2014-11-12 08:54:16 UTC) #4
chrishtr
https://codereview.chromium.org/714303003/diff/1/Source/core/paint/PartPainter.h File Source/core/paint/PartPainter.h (left): https://codereview.chromium.org/714303003/diff/1/Source/core/paint/PartPainter.h#oldcode5 Source/core/paint/PartPainter.h:5: #ifndef SVGRootPainter_h On 2014/11/12 08:54:16, mstensho wrote: > I ...
6 years, 1 month ago (2014-11-12 17:17:22 UTC) #5
leviw_travelin_and_unemployed
Copies don't freak me out. LGTM. http://www.skippydawg.com/Archive/2010/January%202010/1-14/copier.gif
6 years, 1 month ago (2014-11-12 20:01:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714303003/1
6 years, 1 month ago (2014-11-12 20:04:05 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 20:07:12 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185241

Powered by Google App Engine
This is Rietveld 408576698