Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 714123002: Use union type for NavigatorBeacon.sendBeacon()'s data argument (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken, sof, bashi
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use union type for NavigatorBeacon.sendBeacon()'s data argument This lets us lose some overloading and code duplication. BUG=430337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185293

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -72 lines) Patch
M Source/core/loader/BeaconLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/beacon/NavigatorBeacon.h View 1 chunk +2 lines, -9 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.cpp View 2 chunks +19 lines, -56 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.idl View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jens Widell
PTAL Again, this is not ready to land. A code generator bug causes UnionTypesModules.h not ...
6 years, 1 month ago (2014-11-11 13:43:14 UTC) #2
bashi
On 2014/11/11 13:43:14, Jens Widell wrote: > PTAL > > Again, this is not ready ...
6 years, 1 month ago (2014-11-11 23:27:56 UTC) #3
Jens Widell
On 2014/11/11 13:43:14, Jens Widell wrote: > PTAL > > Again, this is not ready ...
6 years, 1 month ago (2014-11-13 11:38:55 UTC) #4
haraken
LGTM
6 years, 1 month ago (2014-11-13 11:48:25 UTC) #5
sof
lgtm
6 years, 1 month ago (2014-11-13 14:51:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714123002/20001
6 years, 1 month ago (2014-11-13 15:00:35 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 15:02:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185293

Powered by Google App Engine
This is Rietveld 408576698