Source/modules/beacon/NavigatorBeacon.idl - Issue 714123002: Use union type for NavigatorBeacon.sendBeacon()'s data argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/beacon/NavigatorBeacon.idl

Issue 714123002: Use union type for NavigatorBeacon.sendBeacon()'s data argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/beacon/NavigatorBeacon.idl

diff --git a/Source/modules/beacon/NavigatorBeacon.idl b/Source/modules/beacon/NavigatorBeacon.idl

index 7b31421a6a0dfff77bded9ae6066468a1603ad38..3595e3f44955b4265da41d84ad3cf36096cbcd41 100644

--- a/Source/modules/beacon/NavigatorBeacon.idl

+++ b/Source/modules/beacon/NavigatorBeacon.idl

@@ -7,9 +7,5 @@

[

RuntimeEnabled=Beacon,

] partial interface Navigator {

- // FIXME: should be union type http://crbug.com/240176

- [CallWith=ExecutionContext, MeasureAs=SendBeacon, RaisesException] boolean sendBeacon(DOMString url, ArrayBufferView data);

- [CallWith=ExecutionContext, MeasureAs=SendBeacon, RaisesException] boolean sendBeacon(DOMString url, Blob data);

- [CallWith=ExecutionContext, MeasureAs=SendBeacon, RaisesException] boolean sendBeacon(DOMString url, FormData data);

- [CallWith=ExecutionContext, MeasureAs=SendBeacon, RaisesException] boolean sendBeacon(DOMString url, [Default=Undefined] optional DOMString data);

+ [CallWith=ExecutionContext, MeasureAs=SendBeacon, RaisesException] boolean sendBeacon(DOMString url, optional (ArrayBufferView or Blob or DOMString or FormData)? data = null);

};

« no previous file with comments | « Source/modules/beacon/NavigatorBeacon.cpp ('k') | no next file » | no next file with comments »