Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: Source/modules/beacon/NavigatorBeacon.h

Issue 714123002: Use union type for NavigatorBeacon.sendBeacon()'s data argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/BeaconLoader.cpp ('k') | Source/modules/beacon/NavigatorBeacon.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/beacon/NavigatorBeacon.h
diff --git a/Source/modules/beacon/NavigatorBeacon.h b/Source/modules/beacon/NavigatorBeacon.h
index c1ded40e634724c2eaa9dba93a9276523394e9f0..d06c9ac0c641d219ba867b1fd67c621a9138c2fb 100644
--- a/Source/modules/beacon/NavigatorBeacon.h
+++ b/Source/modules/beacon/NavigatorBeacon.h
@@ -17,27 +17,20 @@ class DOMFormData;
class ExceptionState;
class ExecutionContext;
class KURL;
+class ArrayBufferViewOrBlobOrStringOrFormData;
class NavigatorBeacon final : public NoBaseWillBeGarbageCollected<NavigatorBeacon>, public WillBeHeapSupplement<Navigator> {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorBeacon);
public:
static NavigatorBeacon& from(Navigator&);
- static bool sendBeacon(ExecutionContext*, Navigator&, const String&, const String&, ExceptionState&);
- static bool sendBeacon(ExecutionContext*, Navigator&, const String&, PassRefPtr<DOMArrayBufferView>, ExceptionState&);
- static bool sendBeacon(ExecutionContext*, Navigator&, const String&, Blob*, ExceptionState&);
- static bool sendBeacon(ExecutionContext*, Navigator&, const String&, PassRefPtrWillBeRawPtr<DOMFormData>, ExceptionState&);
+ static bool sendBeacon(ExecutionContext*, Navigator&, const String&, const ArrayBufferViewOrBlobOrStringOrFormData&, ExceptionState&);
private:
explicit NavigatorBeacon(Navigator&);
static const char* supplementName();
- bool sendBeacon(ExecutionContext*, const String&, const String&, ExceptionState&);
- bool sendBeacon(ExecutionContext*, const String&, PassRefPtr<DOMArrayBufferView>, ExceptionState&);
- bool sendBeacon(ExecutionContext*, const String&, Blob*, ExceptionState&);
- bool sendBeacon(ExecutionContext*, const String&, PassRefPtrWillBeRawPtr<DOMFormData>, ExceptionState&);
-
bool canSendBeacon(ExecutionContext*, const KURL&, ExceptionState&);
int maxAllowance() const;
bool beaconResult(ExecutionContext*, bool allowed, int sentBytes);
« no previous file with comments | « Source/core/loader/BeaconLoader.cpp ('k') | Source/modules/beacon/NavigatorBeacon.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698