IDL: Generic Dictionary support in union types

IDL: Generic Dictionary support in union types

Even though we want to avoid using generic Dictionary in IDL
files, we need them in some cases. For example, WebCrypto
uses generic Dictionary because we don't have IDL dictionary
inheritance support. Add generic Dictionary support so that
such customers can use union types.

BUG=240176
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185189

[bashi, 2014-11-12 05:13:07]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, jl@opera.com

[bashi, 2014-11-12 05:13:08]

PTAL? Here is a background.
https://code.google.com/p/chromium/issues/detail?id=431400

WebCrypto want to use (ArrayBuffer or ArrayBufferView or Dictionary). In
general, I want to avoid adding generic Dictionary special-casing, but it's
somewhat difficult to replace generic Dictionary with IDL dictionary at this
point (dictionary inheritance support is needed)

https://codereview.chromium.org/713403004/diff/1/Source/bindings/templates/un...
File Source/bindings/templates/union.cpp (left):

https://codereview.chromium.org/713403004/diff/1/Source/bindings/templates/un...
Source/bindings/templates/union.cpp:83:
{{container.dictionary_type.cpp_local_type}} cppValue =
V8{{container.dictionary_type.type_name}}::toImpl(isolate, v8Value,
exceptionState);
This was wrong. Union type containers' toImpl() doesn't return a value, but
takes an output argument.

[Jens Widell, 2014-11-12 06:21:45]

lgtm

[haraken, 2014-11-12 07:09:51]

LGTM

[bashi, 2014-11-12 07:12:03]

Thank you for reviews!

[bashi, 2014-11-12 07:12:08]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-11-12 07:12:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713403004/1

[commit-bot: I haz the power, 2014-11-12 07:58:52]

Committed patchset #1 (id:1) as 185189