IDL: Generic Dictionary support in union types

Source/bindings/templates/union.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
 
 #include "config.h"
 #include "{{header_filename}}"
 
 {% macro assign_and_return_if_hasinstance(member) %}
@@ skipping 62 matching lines @@
     {# FIXME: Individual typed arrays (e.g. Uint8Array) aren't supported yet. #}
     {% if container.array_buffer_view_type %}
     {{assign_and_return_if_hasinstance(container.array_buffer_view_type) | indent}}
 
     {% endif %}
     {% if container.dictionary_type %}
     {# 12. Dictionaries #}
     {# FIXME: This should also check "object but not Date or RegExp". Add checks
        when we implement conversions for Date and RegExp. #}
     if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
-        {{container.dictionary_type.cpp_local_type}} cppValue = V8{{container.dictionary_type.type_name}}::toImpl(isolate, v8Value, exceptionState);

[bashi, 2014/11/12 05:13:07]

This was wrong. Union type containers' toImpl() doesn't return a value, but
takes an output argument.

-        if (!exceptionState.hadException())
-            impl.set{{container.dictionary_type.type_name}}(cppValue);
+        {% if container.dictionary_type.type_name != 'Dictionary' %}
+        {{container.dictionary_type.cpp_local_type}} cppValue;
+        {% endif %}
+        {{container.dictionary_type.v8_value_to_local_cpp_value}};
+        impl.set{{container.dictionary_type.type_name}}(cppValue);
         return;
     }
 
     {% endif %}
     {# FIXME: In some cases, we can omit boolean and numeric type checks because
        we have fallback conversions. (step 17 and 18) #}
     {% if container.boolean_type %}
     {# 14. Boolean #}
     if (v8Value->IsBoolean()) {
         impl.setBoolean(v8Value->ToBoolean()->Value());
@@ skipping 57 matching lines @@
 
 {{container.cpp_class}} NativeValueTraits<{{container.cpp_class}}>::nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
 {
     {{container.cpp_class}} impl;
     V8{{container.cpp_class}}::toImpl(isolate, value, impl, exceptionState);
     return impl;
 }
 
 {% endfor %}
 } // namespace blink