IDL: Generic Dictionary support in union types

Source/bindings/scripts/v8_union.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import v8_utilities
 
 
 UNION_H_INCLUDES = frozenset([
+    'bindings/core/v8/Dictionary.h',
     'bindings/core/v8/ExceptionState.h',
     'bindings/core/v8/V8Binding.h',
     'platform/heap/Handle.h',
 ])
 
 cpp_includes = set()
 header_forward_decls = set()
 
 
 def union_context(union_types, interfaces_info):
@@ skipping 42 matching lines @@
         context = member_context(member, interfaces_info)
         members.append(context)
         if member.base_type == 'ArrayBuffer':
             if array_buffer_type:
                 raise Exception('%s is ambiguous.' % union_type.name)
             array_buffer_type = context
         elif member.base_type == 'ArrayBufferView':
             if array_buffer_view_type:
                 raise Exception('%s is ambiguous.' % union_type.name)
             array_buffer_view_type = context
-        elif member.is_interface_type:
-            interface_types.append(context)
-        elif member.is_dictionary:
+        # FIXME: Remove generic Dictionary special casing.
+        elif member.is_dictionary or member.base_type == 'Dictionary':
             if dictionary_type:
                 raise Exception('%s is ambiguous.' % union_type.name)
             dictionary_type = context
+        elif member.is_interface_type:
+            interface_types.append(context)
         elif member is union_type.boolean_member_type:
             boolean_type = context
         elif member is union_type.numeric_member_type:
             numeric_type = context
         elif member is union_type.string_member_type:
             string_type = context
         else:
             raise Exception('%s is not supported as an union member.' % member.name)
 
     # Nullable restriction checks
@@ skipping 31 matching lines @@
         'cpp_type': member.cpp_type_args(used_in_cpp_sequence=True),
         'cpp_local_type': member.cpp_type,
         'cpp_value_to_v8_value': member.cpp_value_to_v8_value(
             cpp_value='impl.getAs%s()' % member.name, isolate='isolate',
             creation_context='creationContext'),
         'is_traceable': member.is_traceable,
         'rvalue_cpp_type': member.cpp_type_args(used_as_rvalue_type=True),
         'specific_type_enum': 'SpecificType' + member.name,
         'type_name': member.name,
         'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(
-            {}, 'v8Value', 'cppValue', needs_exception_state_for_string=True),
+            {}, 'v8Value', 'cppValue', isolate='isolate',
+            needs_exception_state_for_string=True),
     }