Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 712143003: Web Animations API: Interpolate into reference rather than returning new value. (Closed)

Created:
6 years, 1 month ago by shans
Modified:
6 years, 1 month ago
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Web Animations API: Interpolate into reference rather than returning new value. This is a re-work of https://codereview.chromium.org/238313003/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185088

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -35 lines) Patch
M Source/core/animation/InterpolableValue.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/InterpolableValue.cpp View 1 2 chunks +30 lines, -29 lines 0 comments Download
M Source/core/animation/Interpolation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
alancutter (OOO until 2018)
lgtm with nit. Return references are conventionally last in the parameter list.
6 years, 1 month ago (2014-11-11 00:06:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712143003/20001
6 years, 1 month ago (2014-11-11 00:24:20 UTC) #6
dstockwell
lgtm
6 years, 1 month ago (2014-11-11 00:28:30 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:31:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185088

Powered by Google App Engine
This is Rietveld 408576698