Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/core/animation/InterpolableValue.h

Issue 712143003: Web Animations API: Interpolate into reference rather than returning new value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/animation/InterpolableValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/InterpolableValue.h
diff --git a/Source/core/animation/InterpolableValue.h b/Source/core/animation/InterpolableValue.h
index 090f0db62ccedff0dded404d95bca61792cf8328..bc9a009347e923012488fffc0746c5ed011366cf 100644
--- a/Source/core/animation/InterpolableValue.h
+++ b/Source/core/animation/InterpolableValue.h
@@ -25,7 +25,7 @@ public:
virtual void trace(Visitor*) { }
private:
- virtual PassOwnPtrWillBeRawPtr<InterpolableValue> interpolate(const InterpolableValue &to, const double progress) const = 0;
+ virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const = 0;
friend class Interpolation;
@@ -51,7 +51,7 @@ public:
virtual void trace(Visitor* visitor) override { InterpolableValue::trace(visitor); }
private:
- virtual PassOwnPtrWillBeRawPtr<InterpolableValue> interpolate(const InterpolableValue &to, const double progress) const override final;
+ virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const override final;
double m_value;
explicit InterpolableNumber(double value)
@@ -75,7 +75,7 @@ public:
virtual void trace(Visitor* visitor) override { InterpolableValue::trace(visitor); }
private:
- virtual PassOwnPtrWillBeRawPtr<InterpolableValue> interpolate(const InterpolableValue &to, const double progress) const override final;
+ virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const override final;
bool m_value;
explicit InterpolableBool(bool value)
@@ -114,7 +114,7 @@ public:
virtual void trace(Visitor*) override;
private:
- virtual PassOwnPtrWillBeRawPtr<InterpolableValue> interpolate(const InterpolableValue &other, const double progress) const override final;
+ virtual void interpolate(const InterpolableValue& to, const double progress, InterpolableValue& result) const override final;
explicit InterpolableList(size_t size)
: m_size(size)
, m_values(m_size)
@@ -148,7 +148,7 @@ public:
virtual void trace(Visitor*) override;
private:
- virtual PassOwnPtrWillBeRawPtr<InterpolableValue> interpolate(const InterpolableValue &other, const double progress) const override final;
+ virtual void interpolate(const InterpolableValue &to, const double progress, InterpolableValue& result) const override final;
RefPtrWillBeMember<AnimatableValue> m_value;
InterpolableAnimatableValue(PassRefPtrWillBeRawPtr<AnimatableValue> value)
« no previous file with comments | « no previous file | Source/core/animation/InterpolableValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698