Source/core/animation/Interpolation.cpp - Issue 712143003: Web Animations API: Interpolate into reference rather than returning new value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Interpolation.cpp

Issue 712143003: Web Animations API: Interpolate into reference rather than returning new value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/Interpolation.cpp

diff --git a/Source/core/animation/Interpolation.cpp b/Source/core/animation/Interpolation.cpp

index de40c138444855f5b43b4bbef57234c2cea66ac3..2415798a877bc2a312efd41b11a1bdcac155ae45 100644

--- a/Source/core/animation/Interpolation.cpp

+++ b/Source/core/animation/Interpolation.cpp

@@ -47,7 +47,7 @@ Interpolation::Interpolation(PassOwnPtrWillBeRawPtr<InterpolableValue> start, Pa

void Interpolation::interpolate(int iteration, double fraction) const

{

if (m_cachedFraction != fraction || m_cachedIteration != iteration) {

- m_cachedValue = m_start->interpolate(*m_end, fraction);

+ m_start->interpolate(*m_end, fraction, *m_cachedValue);

m_cachedIteration = iteration;

m_cachedFraction = fraction;

}

« no previous file with comments | « Source/core/animation/InterpolableValue.cpp ('k') | no next file » | no next file with comments »