Remove unnecessary paintContainer parameter from addFocusRingRects

Remove unnecessary paintContainer parameter from addFocusRingRects

- Remove the parameter;
- Move RenderObject::addChildFocusRingRects into RenderLayerModelObject
  so that the layerQuads can be mapped by 'this' without the help of
  paintContainer;
- Don't check paintInvalidationContainer in
  RenderInline::addFocusRingRects. The original check and comment
  don't make sense. The element having outline:auto invalidates and
  paints the whole focus ring. The area of the whole focus ring is
  included in the visual overflow of the element.

TEST=existing focus-ring and outline:auto tests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185242

[Xianzhu, 2014-11-06 20:03:33]

wangxianzhu@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Xianzhu, 2014-11-06 20:03:34]

This is not of high priority. Not expecting it into M40.

[dsinclair, 2014-11-06 23:56:22]

lgtm with nit.

https://codereview.chromium.org/711493004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayerModelObject.cpp (right):

https://codereview.chromium.org/711493004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayerModelObject.cpp:219: if (current->isBox()) {
if (!current->isBox()) {
  current->addFocusRingRects(rects, additonalOffset);
  continue;
}

Similar for box->hasLayer below.

[Xianzhu, 2014-11-12 19:10:14]

https://codereview.chromium.org/711493004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayerModelObject.cpp (right):

https://codereview.chromium.org/711493004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayerModelObject.cpp:219: if (current->isBox()) {
On 2014/11/06 23:56:22, dsinclair wrote:
> if (!current->isBox()) {
>   current->addFocusRingRects(rects, additonalOffset);
>   continue;
> }
> 
> Similar for box->hasLayer below.

Done.

[Xianzhu, 2014-11-12 19:14:55]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-11-12 19:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/711493004/20001

[commit-bot: I haz the power, 2014-11-12 20:32:39]

Committed patchset #2 (id:20001) as 185242