Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 710113002: DevTools: remove TimelineModel.Events.RecordAdded event (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove TimelineModel.Events.RecordAdded event All recorded events are processed at once. It doesn't make sense to process them one by one now that we use tracing backend and there are no live updates while the profile is being recorded. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185047

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Messages

Total messages: 7 (2 generated)
yurys
6 years, 1 month ago (2014-11-10 16:09:29 UTC) #2
alph
lgtm https://codereview.chromium.org/710113002/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/710113002/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode831 Source/devtools/front_end/timeline/TimelineFlameChart.js:831: _updateOnAddRecord: function() nuke?
6 years, 1 month ago (2014-11-10 16:19:05 UTC) #3
yurys
https://codereview.chromium.org/710113002/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/710113002/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode831 Source/devtools/front_end/timeline/TimelineFlameChart.js:831: _updateOnAddRecord: function() On 2014/11/10 16:19:05, alph wrote: > nuke? ...
6 years, 1 month ago (2014-11-10 16:19:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710113002/20001
6 years, 1 month ago (2014-11-10 16:20:53 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:39:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185047

Powered by Google App Engine
This is Rietveld 408576698