Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 710113002: DevTools: remove TimelineModel.Events.RecordAdded event (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index 19238696aeff66166e7b7f2acbbf24346b090534..798e8374a6e1a0dfb8b4c07fbc1aa76b8abded45 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -58,9 +58,7 @@ WebInspector.TimelinePanel = function()
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStarted, this._onRecordingStarted, this);
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStopped, this._onRecordingStopped, this);
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordsCleared, this._onRecordsCleared, this);
- this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingProgress, this._onRecordingProgress, this);
this._model.addEventListener(WebInspector.TimelineModel.Events.RecordFilterChanged, this._refreshViews, this);
- this._model.addEventListener(WebInspector.TimelineModel.Events.RecordAdded, this._onRecordAdded, this);
this._categoryFilter = new WebInspector.TimelineCategoryFilter(this._uiUtils);
this._durationFilter = new WebInspector.TimelineIsLongFilter();
@@ -760,14 +758,6 @@ WebInspector.TimelinePanel.prototype = {
/**
* @param {!WebInspector.Event} event
*/
- _onRecordingProgress: function(event)
- {
- this._updateProgress(WebInspector.UIString("%d events collected", event.data));
- },
-
- /**
- * @param {!WebInspector.Event} event
- */
_onTracingBufferUsage: function(event)
{
var usage = /** @type {number} */ (event.data);
@@ -815,18 +805,6 @@ WebInspector.TimelinePanel.prototype = {
/**
* @param {!WebInspector.Event} event
*/
- _onRecordAdded: function(event)
- {
- var record = /** @type {!WebInspector.TimelineModel.Record} */ (event.data);
- if (this._lazyFrameModel && !this._tracingModel)
- this._lazyFrameModel.addRecord(record);
- for (var i = 0; i < this._currentViews.length; ++i)
- this._currentViews[i].addRecord(record);
- },
-
- /**
- * @param {!WebInspector.Event} event
- */
_willReloadPage: function(event)
{
if (this._operationInProgress || this._userInitiatedRecording || !this.isShowing())
@@ -1325,11 +1303,6 @@ WebInspector.TimelineModeView.prototype = {
refreshRecords: function(textFilter) {},
/**
- * @param {!WebInspector.TimelineModel.Record} record
- */
- addRecord: function(record) {},
-
- /**
* @param {?WebInspector.TimelineModel.Record} record
* @param {string=} regex
* @param {boolean=} selectRecord
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineModel.js ('k') | Source/devtools/front_end/timeline/TimelinePowerGraph.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698