Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 710113002: DevTools: remove TimelineModel.Events.RecordAdded event (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 2faa97c5c0c2a1c3bf81c68dba36c312932eadc9..4205dc4ed2e33dbb363325f206ab9173bd73c005 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -792,6 +792,7 @@ WebInspector.TimelineFlameChart.prototype = {
},
/**
+ * @override
* @param {?RegExp} textFilter
*/
refreshRecords: function(textFilter)
@@ -828,31 +829,6 @@ WebInspector.TimelineFlameChart.prototype = {
},
/**
- * @param {!WebInspector.TimelineModel.Record} record
- */
- addRecord: function(record)
- {
- this._dataProvider.reset();
- if (this._automaticallySizeWindow) {
- var minimumRecordTime = this._model.minimumRecordTime();
- if (record.startTime() > (minimumRecordTime + 1000)) {
- this._automaticallySizeWindow = false;
- this._delegate.requestWindowTimes(minimumRecordTime, minimumRecordTime + 1000);
- }
- this._mainView.scheduleUpdate();
- } else {
- if (!this._pendingUpdateTimer)
- this._pendingUpdateTimer = window.setTimeout(this._updateOnAddRecord.bind(this), 300);
- }
- },
-
- _updateOnAddRecord: function()
- {
- delete this._pendingUpdateTimer;
- this._mainView.scheduleUpdate();
- },
-
- /**
* @param {number} startTime
* @param {number} endTime
*/
« no previous file with comments | « Source/devtools/front_end/timeline/MemoryCountersGraph.js ('k') | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698