Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: extensions/renderer/messaging_bindings.cc

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/messaging_bindings.h" 5 #include "extensions/renderer/messaging_bindings.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 v8::Handle<v8::Value> arguments[] = { 275 v8::Handle<v8::Value> arguments[] = {
276 // portId 276 // portId
277 v8::Integer::New(isolate, target_port_id), 277 v8::Integer::New(isolate, target_port_id),
278 // channelName 278 // channelName
279 v8::String::NewFromUtf8(isolate, 279 v8::String::NewFromUtf8(isolate,
280 channel_name.c_str(), 280 channel_name.c_str(),
281 v8::String::kNormalString, 281 v8::String::kNormalString,
282 channel_name.size()), 282 channel_name.size()),
283 // sourceTab 283 // sourceTab
284 tab, 284 tab,
285 // source_frame_id
286 v8::Integer::New(isolate, info.source_frame_id),
285 // sourceExtensionId 287 // sourceExtensionId
286 v8::String::NewFromUtf8(isolate, 288 v8::String::NewFromUtf8(isolate,
287 info.source_id.c_str(), 289 info.source_id.c_str(),
288 v8::String::kNormalString, 290 v8::String::kNormalString,
289 info.source_id.size()), 291 info.source_id.size()),
290 // targetExtensionId 292 // targetExtensionId
291 v8::String::NewFromUtf8(isolate, 293 v8::String::NewFromUtf8(isolate,
292 target_extension_id.c_str(), 294 target_extension_id.c_str(),
293 v8::String::kNormalString, 295 v8::String::kNormalString,
294 target_extension_id.size()), 296 target_extension_id.size()),
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 const ScriptContextSet& context_set, 420 const ScriptContextSet& context_set,
419 int port_id, 421 int port_id,
420 const std::string& error_message, 422 const std::string& error_message,
421 content::RenderView* restrict_to_render_view) { 423 content::RenderView* restrict_to_render_view) {
422 context_set.ForEach( 424 context_set.ForEach(
423 restrict_to_render_view, 425 restrict_to_render_view,
424 base::Bind(&DispatchOnDisconnectToScriptContext, port_id, error_message)); 426 base::Bind(&DispatchOnDisconnectToScriptContext, port_id, error_message));
425 } 427 }
426 428
427 } // namespace extensions 429 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698