Source/bindings/core/v8/V8ObjectConstructor.cpp - Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ObjectConstructor.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ObjectConstructor.cpp

diff --git a/Source/bindings/core/v8/V8ObjectConstructor.cpp b/Source/bindings/core/v8/V8ObjectConstructor.cpp

index f6c01e0355f0d7635129aa57764b3249a0f4199f..d03639b65aee8ee2f71981a0531cabd39da81b6d 100644

--- a/Source/bindings/core/v8/V8ObjectConstructor.cpp

+++ b/Source/bindings/core/v8/V8ObjectConstructor.cpp

@@ -59,7 +59,7 @@ v8::Local<v8::Object> V8ObjectConstructor::newInstanceInDocument(v8::Isolate* is

void V8ObjectConstructor::isValidConstructorMode(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (ConstructorMode::current(info.GetIsolate()) == ConstructorMode::CreateNewObject) {

- V8ThrowException::throwTypeError("Illegal constructor", info.GetIsolate());

+ V8ThrowException::throwTypeError(info.GetIsolate(), "Illegal constructor");

return;

}

v8SetReturnValue(info, info.This());

« no previous file with comments | « Source/bindings/core/v8/ScriptPromise.cpp ('k') | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »