Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 709103002: Allow Blink to respond asynchronously to SW Push events (side 2/3) (Closed)

Created:
6 years, 1 month ago by johnme
Modified:
6 years, 1 month ago
Reviewers:
michaeln, Mike West
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, Michael van Ouwerkerk
Project:
blink
Visibility:
Public.

Description

Allow Blink to respond asynchronously to SW Push events (side 2/3) This will be necessary once Push events support event.waitUntil to keep the Service Worker alive until the Promise is resolved (https://github.com/w3c/push-api/issues/85). Depends on Chromium https://codereview.chromium.org/708913003 Required by Chromium https://codereview.chromium.org/707243003 BUG=430888, 401438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
johnme
michaeln@chromium.org: Please review the overall patch, and give OWNERS approval for Source/modules/serviceworkers/ mkwst@chromium.org: Please give ...
6 years, 1 month ago (2014-11-07 18:43:56 UTC) #2
Mike West
Assuming michaeln@ is happy with the patch, */web LGTM
6 years, 1 month ago (2014-11-07 19:14:15 UTC) #3
michaeln
lgtm 2
6 years, 1 month ago (2014-11-08 00:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709103002/1
6 years, 1 month ago (2014-11-08 19:52:44 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 20:54:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185008

Powered by Google App Engine
This is Rietveld 408576698