Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 708913003: Allow Blink to respond asynchronously to SW Push events (side 1/3) (Closed)

Created:
6 years, 1 month ago by johnme
Modified:
6 years, 1 month ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow Blink to respond asynchronously to SW Push events (side 1/3) This will be necessary once Push events support event.waitUntil to keep the Service Worker alive until the Promise is resolved (https://github.com/w3c/push-api/issues/85). Required by Blink https://codereview.chromium.org/709103002 BUG=430888, 401438 Committed: https://crrev.com/22e04357bc9bcfe37aa8de313fe7081944daadda Cr-Commit-Position: refs/heads/master@{#303365}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
johnme
6 years, 1 month ago (2014-11-07 18:40:56 UTC) #2
Michael van Ouwerkerk
https://codereview.chromium.org/708913003/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc File content/renderer/service_worker/embedded_worker_context_client.cc (right): https://codereview.chromium.org/708913003/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc#newcode322 content/renderer/service_worker/embedded_worker_context_client.cc:322: blink::WebServiceWorkerEventResult result) { Might add something like "TODO: implement ...
6 years, 1 month ago (2014-11-07 18:59:06 UTC) #4
michaeln
lgtm 3
6 years, 1 month ago (2014-11-08 00:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708913003/1
6 years, 1 month ago (2014-11-08 01:02:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 02:53:20 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 02:54:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22e04357bc9bcfe37aa8de313fe7081944daadda
Cr-Commit-Position: refs/heads/master@{#303365}

Powered by Google App Engine
This is Rietveld 408576698