Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 707243003: Allow Blink to respond asynchronously to SW Push events (side 3/3) (Closed)

Created:
6 years, 1 month ago by johnme
Modified:
6 years, 1 month ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@async_push_finished
Project:
chromium
Visibility:
Public.

Description

Allow Blink to respond asynchronously to SW Push events (side 3/3) This will be necessary once Push events support event.waitUntil to keep the Service Worker alive until the Promise is resolved (https://github.com/w3c/push-api/issues/85). Depends on Blink https://codereview.chromium.org/709103002 BUG=430888, 401438 Committed: https://crrev.com/1763c3912ccad6045d94f29e977e605409edaadd Cr-Commit-Position: refs/heads/master@{#303454}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
johnme
6 years, 1 month ago (2014-11-07 18:44:19 UTC) #2
michaeln
lgtm
6 years, 1 month ago (2014-11-08 00:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707243003/1
6 years, 1 month ago (2014-11-09 13:15:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/15738)
6 years, 1 month ago (2014-11-09 13:20:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707243003/20001
6 years, 1 month ago (2014-11-10 11:37:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-10 13:19:54 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 13:20:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1763c3912ccad6045d94f29e977e605409edaadd
Cr-Commit-Position: refs/heads/master@{#303454}

Powered by Google App Engine
This is Rietveld 408576698