Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709003006: cleanup friends in GrGpu (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup_geometry_handling
Project:
skia
Visibility:
Public.

Description

simple cl to cleanup friends in GrGpu BUG=skia: Committed: https://skia.googlesource.com/skia/+/4b68ec08c69ee9f17e13fce2094bb04b12b54856

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -56 lines) Patch
M src/gpu/GrDrawTarget.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 1 5 chunks +21 lines, -25 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
6 years, 1 month ago (2014-11-07 20:12:29 UTC) #3
bsalomon
https://codereview.chromium.org/709003006/diff/1/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/709003006/diff/1/src/gpu/GrGpu.h#newcode505 src/gpu/GrGpu.h:505: virtual void onGpuClear(GrRenderTarget*, const SkIRect* rect, GrColor color, Can ...
6 years, 1 month ago (2014-11-07 21:00:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709003006/40001
6 years, 1 month ago (2014-11-07 22:03:36 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 22:11:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4b68ec08c69ee9f17e13fce2094bb04b12b54856

Powered by Google App Engine
This is Rietveld 408576698