MIPS: Resolve chromium and android webview build conflicts.

MIPS: Resolve chromium and android webview build conflicts.

The mips related gyp variables and compiler flags for webview
and chromium builds are set externally. The CL ensures this
behaviour and prevents conflicts in configuration with standalone builds.

TEST=
BUG=
R=jkummerow@chromium.org, paul.lind@imgtec.com

Committed: https://code.google.com/p/v8/source/detail?r=25243

[paul.l..., 2014-11-07 01:13:20]

paul.lind@imgtec.com changed reviewers:
+ paul.lind@imgtec.com

[paul.l..., 2014-11-07 01:13:20]

It currently does not pass the right flags to a mipsel.release standalone v8
build. 

I defined the cross-compilation env vars, e.g.:
CXX=/mips/arch/overflow/codesourcery/mips-linux-gnu/lite/release/2013.11-36/Linux/bin/mips-linux-gnu-g++

And did 'make mipsel.release'

There is no -EL flag, it builds this target for big-endian.

There are no -mips32r2 flags, but I presume the compiler must default to that,
since the obj files and final linked executable are mips32r2 (but are
big-endian).

I did not do any GYPFLAGS or anything, but should not need that for r2 mipsel
build.

Here are the target compile flags:

/mips/arch/overflow/codesourcery/mips-linux-gnu/lite/release/2013.11-36/Linux/bin/mips-linux-gnu-g++
'-DV8_TARGET_ARCH_MIPS' '-DCAN_USE_FPU_INSTRUCTIONS' '-D__mips_hard_float=1'
'-DV8_DEPRECATION_WARNINGS' '-DV8_I18N_SUPPORT'
'-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DU_USING_ICU_NAMESPACE=0'
'-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION' '-DENABLE_HANDLE_ZAPPING'
-I../. -I../third_party/icu/source/i18n -I../third_party/icu/source/common 
-Wall -Werror -W -Wno-unused-parameter -Wno-long-long -pthread -fno-exceptions
-pedantic -Wno-missing-field-initializers -fdata-sections -ffunction-sections
-O3 -fdata-sections -ffunction-sections -O3 -Wnon-virtual-dtor -fno-rtti
-std=gnu++0x -MMD -MF
/opt/paul/v8/goog-v8-4/out/mipsel.release/.deps//opt/paul/v8/goog-v8-4/out/mipsel.release/obj.target/v8_base/src/api.o.d.raw
 -c -o /opt/paul/v8/goog-v8-4/out/mipsel.release/obj.target/v8_base/src/api.o
../src/api.cc

[dusmil.imgtec, 2014-11-07 13:23:41]

Typo mistakes resolved.

[dusmil.imgtec, 2014-11-07 13:25:32]

dusan.milosavljevic@imgtec.com changed reviewers:
+ danno@chromium.org, jkummerow@chromium.org

[dusmil.imgtec, 2014-11-07 13:25:33]

PTAL.

[Jakob Kummerow, 2014-11-07 14:15:51]

rubberstamp LGTM so you can land. Since this doesn't affect non-MIPS, I'm
leaving the detailed review to Paul.

[paul.l..., 2014-11-07 18:14:58]

Still a few problems in standalone builds for mipsel and mips targets. Please
see comments. I did not test mips64el thoroughly yet.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi
File build/toolchain.gypi (right):

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:289: ['v8_target_arch==target and
android_webview_build==0', {
'target' needs to be 'target_arch' here.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:319: 'FPU_MODE_FP64',
Need to add '-mfp64' to 'cflags' here, and '-mfpxx' and '-mfp32' in the clauses
below.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:455: '_MIPS_ARCH_MIPS32R2',
Need 'cflags' set to mfp64, -mfpxx, -mfpxx in these clauses also, I think.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:583: 'cflags': ['-mips64r6', '-mabi=64', '-Wa,-mips64r6'],
We should probably do -mfp64 in here somewhere too, though the defaults from the
compiler would mostly likely get that anyway.

[dusmil.imgtec, 2014-11-07 19:06:23]

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi
File build/toolchain.gypi (right):

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:289: ['v8_target_arch==target and
android_webview_build==0', {
On 2014/11/07 18:14:57, paul.l... wrote:
> 'target' needs to be 'target_arch' here.

Done.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:319: 'FPU_MODE_FP64',
Thank you for spotting this.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:319: 'FPU_MODE_FP64',
On 2014/11/07 18:14:57, paul.l... wrote:
> Need to add '-mfp64' to 'cflags' here, and '-mfpxx' and '-mfp32' in the
clauses
> below.

Done.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:455: '_MIPS_ARCH_MIPS32R2',
On 2014/11/07 18:14:57, paul.l... wrote:
> Need 'cflags' set to mfp64, -mfpxx, -mfpxx in these clauses also, I think.

Done.

https://codereview.chromium.org/707883002/diff/20001/build/toolchain.gypi#new...
build/toolchain.gypi:583: 'cflags': ['-mips64r6', '-mabi=64', '-Wa,-mips64r6'],
there is no need for this, since mips64 always implies mfp64.

[paul.l..., 2014-11-08 06:51:31]

LGTM.

[dusmil.imgtec, 2014-11-10 11:48:03]

Committed patchset #4 (id:60001) manually as 25243 (presubmit successful).