Refactor Autofill for OOPIF

Refactor Autofill for OOPIF

Chromium side: https://codereview.chromium.org/707173004/

BUG=425756, 400186

[Evan Stade, 2014-11-17 18:49:51]

estade@chromium.org changed reviewers:
+ mkwst@chromium.org, vabr@chromium.org

[Evan Stade, 2014-11-17 18:52:48]

+mkwst for review
+vabr for FYI/review

I'm not quite sure how to split this up so that it can be landed before the
Chromium side and without breaking things.

[vabr (Chromium), 2014-11-18 09:32:24]

This LGTM, although I have no OWNERS powers in Blink.

For the non-breaking transition, my instinct would be to add new stuff without
deleting the old stuff first (e.g., where a frame was added to the signature,
keep 2 copies of the method, one with and one without a frame), and mark the old
stuff with a FIXME indicating the Chromium CL blocking its deletion. Then land
the Chromium CL, and finally clean up the old stuff in Blink. I have no idea if
that would be acceptable in Blink, but perhaps Mike does?

Cheers,
Vaclav

[Mike West, 2014-11-18 09:40:32]

On 2014/11/18 09:32:24, vabr (Chromium) wrote:
> This LGTM, although I have no OWNERS powers in Blink.

The general approach looks perfectly reasonable, but you won't be able to land
this in Chromium as-is (as you already noted).

> For the non-breaking transition, my instinct would be to add new stuff without
> deleting the old stuff first (e.g., where a frame was added to the signature,
> keep 2 copies of the method, one with and one without a frame), and mark the
old
> stuff with a FIXME indicating the Chromium CL blocking its deletion. Then land
> the Chromium CL, and finally clean up the old stuff in Blink. I have no idea
if
> that would be acceptable in Blink, but perhaps Mike does?

Right. You'll end up with a three-sided patch:

1) Add the new Frame-based interface to Blink.
1a) Wait for this patch to roll into Chromium.
2) Switch Chromium to use the new Frame-based interface.
3) Remove the View-based interface.

https://codereview.chromium.org/732963003/ isn't the same thing, but it's a good
example of the style of patch you'll end up with (and the CL description nicely
includes links to all the CLs, which is helpful while reviewing).