Source/web/ChromeClientImpl.h - Issue 707723002: Refactor Autofill for OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 707723002: Refactor Autofill for OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: more stuff Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index f230cabb3a30cd4354fbcf9cb61cb86742191276..260fac7067bcffc949e1b0843a882fdf260a2e8b 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -125,7 +125,6 @@ public:

virtual bool paintCustomOverhangArea(GraphicsContext*, const IntRect&, const IntRect&, const IntRect&) override;

virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;

virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;

- virtual void openTextDataListChooser(HTMLInputElement&) override;

virtual void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) override;

virtual void enumerateChosenDirectory(FileChooser*) override;

virtual void setCursor(const Cursor&) override;

@@ -164,10 +163,12 @@ public:

virtual bool requestPointerLock() override;

virtual void requestPointerUnlock() override;

- virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element> >&) override;

+ // AutofillClient pass throughs:

+ virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element> >&, LocalFrame*) override;

+ virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent&) override;

virtual void didChangeValueInTextField(HTMLFormControlElement&) override;

virtual void didEndEditingOnTextField(HTMLInputElement&) override;

- virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent&) override;

+ virtual void openTextDataListChooser(HTMLInputElement&) override;

virtual void didCancelCompositionOnSelectionChange() override;

virtual void willSetInputMethodState() override;

« no previous file with comments | « Source/core/page/ChromeClient.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »