Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 707243003: Allow Blink to respond asynchronously to SW Push events (side 3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async_push_finished
Patch Set: Fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 9aa65d5661b8de5cea8cff80e8c0d87a61bfce04..fe8e4446af094566a674c4e32898f7af64fc778a 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -129,6 +129,14 @@ void ServiceWorkerScriptContext::DidHandleFetchEvent(
GetRoutingID(), request_id, result, response));
}
+void ServiceWorkerScriptContext::DidHandlePushEvent(
+ int request_id,
+ blink::WebServiceWorkerEventResult unused) {
+ // TODO(johnme): Plumb through the result.
+ Send(new ServiceWorkerHostMsg_PushEventFinished(
+ GetRoutingID(), request_id));
+}
+
void ServiceWorkerScriptContext::DidHandleSyncEvent(int request_id) {
Send(new ServiceWorkerHostMsg_SyncEventFinished(
GetRoutingID(), request_id));
@@ -222,8 +230,6 @@ void ServiceWorkerScriptContext::OnPushEvent(int request_id,
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerScriptContext::OnPushEvent");
proxy_->dispatchPushEvent(request_id, blink::WebString::fromUTF8(data));
- Send(new ServiceWorkerHostMsg_PushEventFinished(
- GetRoutingID(), request_id));
}
void ServiceWorkerScriptContext::OnGeofencingEvent(
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698