Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 707093002: Teach PRESUBMIT.py how to run gn check for most of the mojo repo (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Teach PRESUBMIT.py how to run gn check for most of the mojo repo Almost all of the mojo-forked code now passes gn check. I used: https://github.com/domokit/mojo/wiki/Directory-guide for the list of mojo-forked directories. gn check //mojo/* was 152 errors and is now down to 52. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dea154634ceba9cb855619259aa643857b9995ac

Patch Set 1 #

Patch Set 2 : fix edk #

Patch Set 3 : update after hans landed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -32 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/application/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/application_manager/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/apps/js/bindings/BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/aura/BUILD.gn View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/js/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/window_manager/BUILD.gn View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 2 7 chunks +29 lines, -7 lines 0 comments Download
M mojo/spy/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/tools/package_manager/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/views/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-11-07 01:04:08 UTC) #1
jamesr
I think the //mojo/edk/js changes may conflict with Hans' patch, so hold off on that, ...
6 years, 1 month ago (2014-11-07 01:29:54 UTC) #2
eseidel
6 years, 1 month ago (2014-11-07 17:18:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
dea154634ceba9cb855619259aa643857b9995ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698