Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(79)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mojo/apps/js/bindings/BUILD.gn
Issue
707093002
:
Teach PRESUBMIT.py how to run gn check for most of the mojo repo (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set: update after hans landed
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
PRESUBMIT.py
mojo/application/BUILD.gn
mojo/application_manager/BUILD.gn
mojo/apps/js/BUILD.gn
mojo/apps/js/bindings/BUILD.gn
mojo/apps/js/bindings/gl/BUILD.gn
mojo/aura/BUILD.gn
mojo/cc/BUILD.gn
mojo/common/BUILD.gn
mojo/edk/embedder/BUILD.gn
mojo/edk/js/BUILD.gn
mojo/edk/system/BUILD.gn
mojo/services/window_manager/BUILD.gn
mojo/shell/BUILD.gn
mojo/spy/BUILD.gn
mojo/tools/package_manager/BUILD.gn
mojo/views/BUILD.gn
sky/engine/platform/BUILD.gn
View unified diff
|
Download patch
« no previous file with comments
|
« mojo/apps/js/BUILD.gn
('k') |
mojo/apps/js/bindings/gl/BUILD.gn »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.
1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
3 # found in the LICENSE file.
4
4
5 source_set("bindings") {
5 source_set("bindings") {
6 deps = [
6 deps = [
7 "//base",
7 "//base",
8 "//gin",
8 "//gin",
9
"//mojo/edk/js",
10
"//mojo/public/cpp/system",
9 "//v8",
11 "//v8",
10
"//mojo/edk/js",
11 ]
12 ]
12
13
13 sources = [
14 sources = [
14 "monotonic_clock.cc",
15 "monotonic_clock.cc",
15 "monotonic_clock.h",
16 "monotonic_clock.h",
16 ]
17 ]
17 }
18 }
OLD
NEW
« no previous file with comments
|
« mojo/apps/js/BUILD.gn
('k') |
mojo/apps/js/bindings/gl/BUILD.gn »
('j') |
no next file with comments »
Issue 707093002: Teach PRESUBMIT.py how to run gn check for most of the mojo repo (Closed)
Created 6 years, 1 month ago by eseidel
Modified 6 years, 1 month ago
Reviewers: jamesr
Base URL: git@github.com:domokit/mojo.git@master
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 707093002:
Teach PRESUBMIT.py how to run gn check for most of the mojo repo (Closed)
Base URL: git@github.com:domokit/mojo.git@master