PRESUBMIT.py - Issue 707093002: Teach PRESUBMIT.py how to run gn check for most of the mojo repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 707093002: Teach PRESUBMIT.py how to run gn check for most of the mojo repo (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: update after hans landed Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 79de95ffa95303e779f89fe9b4100687620f6f05..3c8babe97b7cfe731d40f19b32502222a9b15241 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -444,7 +444,20 @@ def _CheckGNCheck(input_api, output_api):

# TODO(eseidel): Currently only these are known to pass,

# once everything passes we can just call 'gn check' once without a filter!

KNOWN_PASSING = [

+ '//build/*',

+ '//mojo/application/*',

+ '//mojo/apps/*',

+ '//mojo/aura/*',

+ '//mojo/cc/*',

+ '//mojo/common/*',

'//mojo/public/*',

+ '//mojo/spy/*',

+ '//mojo/tools/*',

+ '//mojo/views/*',

+ '//skia/*',

+ '//testing/*',

+ '//tools/*',

+ '//ui/*',

]

if input_api.platform != 'win32':

KNOWN_PASSING += [

« no previous file with comments | « no previous file | mojo/application/BUILD.gn » ('j') | no next file with comments »