Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 706823004: OOP PDF: Change the save toolbar button to match the save menu behavior. (Closed)

Created:
6 years, 1 month ago by Sam McNally
Modified:
6 years, 1 month ago
Reviewers:
kenrb, Fady Samuel, jam, raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@embedded-pdfs
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Change the save toolbar button to match the save menu behavior. Previously, the save toolbar button for the out-of-process PDF plugin was a link to the PDF URL. This did not function for file URLs or PDFs returned in response to a POST. This changes the button to use the pepper PDF save API and adds a way for a WebContentsDelegate to override SaveFrame behavior so the MimeHandlerViewGuest can instruct its embedder to handle the actual save. BUG=416329 TEST=Run with --out-of-process-pdf. Open a local PDF and click the save toolbar button. The save as dialog should appear. Repeat the same with a PDF returned by a POST request. Saving should save the opened PDF - not the page returned by a GET to the same URL. Committed: https://crrev.com/92af61555dff60e1d1b51c47d27d07c5a643726d Cr-Commit-Position: refs/heads/master@{#304920}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -18 lines) Patch
M chrome/browser/resources/pdf/index.html View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 3 chunks +11 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/mime_handler_view_container.cc View 1 chunk +2 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Sam McNally
6 years, 1 month ago (2014-11-13 00:48:54 UTC) #2
raymes
lgtm
6 years, 1 month ago (2014-11-13 06:30:06 UTC) #4
raymes
+fsamuel@ for browser-plugin related code
6 years, 1 month ago (2014-11-13 06:31:08 UTC) #6
Fady Samuel
guest_view lgtm
6 years, 1 month ago (2014-11-13 14:53:28 UTC) #7
Sam McNally
+jam for content
6 years, 1 month ago (2014-11-13 22:40:21 UTC) #9
jam
lgtm
6 years, 1 month ago (2014-11-14 17:32:29 UTC) #10
Sam McNally
+kenrb for extensions/common/extension_messages.h
6 years, 1 month ago (2014-11-16 23:29:22 UTC) #12
Sam McNally
kenrb: ping
6 years, 1 month ago (2014-11-19 03:55:20 UTC) #13
kenrb
Sorry for the delay. ipc lgtm
6 years, 1 month ago (2014-11-19 16:45:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706823004/40001
6 years, 1 month ago (2014-11-19 22:32:39 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-19 23:27:54 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 23:28:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92af61555dff60e1d1b51c47d27d07c5a643726d
Cr-Commit-Position: refs/heads/master@{#304920}

Powered by Google App Engine
This is Rietveld 408576698