extensions/renderer/guest_view/mime_handler_view_container.cc - Issue 706823004: OOP PDF: Change the save toolbar button to match the save menu behavior.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/guest_view/mime_handler_view_container.cc

Issue 706823004: OOP PDF: Change the save toolbar button to match the save menu behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@embedded-pdfs

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/common/extension_messages.h ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "extensions/renderer/guest_view/mime_handler_view_container.h"	5 #include "extensions/renderer/guest_view/mime_handler_view_container.h"

6	6

7 #include "content/public/renderer/render_frame.h"	7 #include "content/public/renderer/render_frame.h"

8 #include "extensions/common/extension_messages.h"	8 #include "extensions/common/extension_messages.h"

9 #include "extensions/common/guest_view/guest_view_constants.h"	9 #include "extensions/common/guest_view/guest_view_constants.h"

10 #include "third_party/WebKit/public/web/WebDocument.h"	10 #include "third_party/WebKit/public/web/WebDocument.h"

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90	90

91 void MimeHandlerViewContainer::CreateMimeHandlerViewGuest() {	91 void MimeHandlerViewContainer::CreateMimeHandlerViewGuest() {

92 // The loader has completed loading \|html_string_\| so we can dispose it.	92 // The loader has completed loading \|html_string_\| so we can dispose it.

93 loader_.reset();	93 loader_.reset();

94	94

95 // Parse the stream URL to ensure it's valid.	95 // Parse the stream URL to ensure it's valid.

96 GURL stream_url(html_string_);	96 GURL stream_url(html_string_);

97	97

98 DCHECK_NE(element_instance_id(), guestview::kInstanceIDNone);	98 DCHECK_NE(element_instance_id(), guestview::kInstanceIDNone);

99 render_frame()->Send(new ExtensionHostMsg_CreateMimeHandlerViewGuest(	99 render_frame()->Send(new ExtensionHostMsg_CreateMimeHandlerViewGuest(

100 routing_id(), stream_url.spec(), mime_type_, element_instance_id()));	100 routing_id(), stream_url.spec(), original_url_.spec(), mime_type_,

	101 element_instance_id()));

101 }	102 }

102	103

103 } // namespace extensions	104 } // namespace extensions

OLD	NEW