extensions/browser/extension_message_filter.cc - Issue 706823004: OOP PDF: Change the save toolbar button to match the save menu behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_message_filter.cc

Issue 706823004: OOP PDF: Change the save toolbar button to match the save menu behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@embedded-pdfs

Patch Set: rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/extension_message_filter.h ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_message_filter.cc

diff --git a/extensions/browser/extension_message_filter.cc b/extensions/browser/extension_message_filter.cc

index 80e395ad1c8ba1c2699aafcceb23fafc3f587264..80bccb542c856b051240429f320757e0a0fa91f9 100644

--- a/extensions/browser/extension_message_filter.cc

+++ b/extensions/browser/extension_message_filter.cc

@@ -178,6 +178,7 @@ void ExtensionMessageFilter::OnExtensionAttachGuest(

void ExtensionMessageFilter::OnExtensionCreateMimeHandlerViewGuest(

int render_frame_id,

const std::string& src,

+ const std::string& content_url,

const std::string& mime_type,

int element_instance_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

@@ -203,6 +204,7 @@ void ExtensionMessageFilter::OnExtensionCreateMimeHandlerViewGuest(

base::DictionaryValue create_params;

create_params.SetString(mime_handler_view::kMimeType, mime_type);

create_params.SetString(mime_handler_view::kSrc, src);

+ create_params.SetString(mime_handler_view::kContentUrl, content_url);

manager->CreateGuest(MimeHandlerViewGuest::Type,

"",

embedder_web_contents,