Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 70653003: Add DEPS roll support to got_XXX_revision. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, csharp, Vadim Sh.
Base URL:
https://chromium.googlesource.com/a/chromium/tools/build.git@master
Visibility:
Public.

Description

Add DEPS roll support to got_XXX_revision. It is needed to test swarming_client properly. This is because the got_swarming_client_revision is used to propagate in the triggered build on *_swarm_triggered. So for a DEPS roll to work with apply_issue, the property must be set properly. R=stip@chromium.org BUG=170427 ABANDONNED.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M scripts/master/chromium_step.py View 3 chunks +24 lines, -7 lines 1 comment Download
M scripts/slave/chromium_commands.py View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
- I tested manually with a full setup and triggering a build manually and manually ...
7 years, 1 month ago (2013-11-14 02:07:19 UTC) #1
M-A Ruel
On 2013/11/14 02:07:19, M-A Ruel wrote: > - I tested manually with a full setup ...
7 years, 1 month ago (2013-11-14 18:56:42 UTC) #2
ghost stip (do not use)
this is not the right way. I am working on a replacement https://codereview.chromium.org/70653003/diff/1/scripts/master/chromium_step.py File scripts/master/chromium_step.py ...
7 years, 1 month ago (2013-11-14 22:25:40 UTC) #3
M-A Ruel
On 2013/11/14 22:25:40, stip wrote: > this is not the right way. I am working ...
7 years, 1 month ago (2013-11-17 20:11:11 UTC) #4
ghost stip (do not use)
http://mybroadband.co.za/vb/attachment.php?attachmentid=19597&d=1348058492
7 years, 1 month ago (2013-11-18 17:37:18 UTC) #5
ghost stip (do not use)
7 years, 1 month ago (2013-11-19 22:42:08 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698