Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: scripts/slave/chromium_commands.py

Issue 70653003: Add DEPS roll support to got_XXX_revision. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/tools/build.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/master/chromium_step.py ('K') | « scripts/master/chromium_step.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium_commands.py
diff --git a/scripts/slave/chromium_commands.py b/scripts/slave/chromium_commands.py
index 26ee71ad6f36dc0e65c4cec05428ffe7f14c2e2b..a6dc0aae4ef171526c8d99b29b81376ae81f51ef 100644
--- a/scripts/slave/chromium_commands.py
+++ b/scripts/slave/chromium_commands.py
@@ -632,6 +632,7 @@ class ApplyIssue(Command):
self.workdir = None
self.timeout = None
self.server = None
+ self.command = None
chromium_utils.GetParentClass(ApplyIssue).__init__(self, *args, **kwargs)
def _doApplyIssue(self, _):
@@ -649,10 +650,10 @@ class ApplyIssue(Command):
if self.server:
cmd.extend(['-s', self.server])
- command = runprocess.RunProcess(
+ self.command = runprocess.RunProcess(
self.builder, cmd, os.path.join(self.builder.basedir, self.workdir),
- timeout=self.timeout)
- return command.start()
+ timeout=self.timeout, keepStdout=True)
+ return self.command.start()
# Command overrides:
@@ -670,8 +671,12 @@ class ApplyIssue(Command):
log.msg('ApplyIssue.start')
d = defer.succeed(None)
d.addCallback(self._doApplyIssue)
+ d.addCallback(self._parseGotRevision)
return d
+ def _parseGotRevision(self, command):
+ return self.sendStatus(extract_revisions(self.command.stdout))
+
def RegisterCommands():
"""Registers all command objects defined in this file."""
« scripts/master/chromium_step.py ('K') | « scripts/master/chromium_step.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698