Add DEPS roll support to got_XXX_revision.

scripts/master/chromium_step.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Subclasses of various slave command classes."""
 
 import copy
 import errno
 import json
 import logging
 import os
 import time
 
 from twisted.python import log
 
 from buildbot import interfaces, util
 from buildbot.process import buildstep
 from buildbot.process.properties import WithProperties
 from buildbot.status import builder
 from buildbot.steps import shell
 from buildbot.steps import source
 from buildbot.process.buildstep import LoggingBuildStep
 
 from common import annotator
 from common import chromium_utils
 import config
 
 
+GOT_REVISION_PROPERTIES = (
+    ('got_nacl_revision', 'got_nacl_revision'),
+    ('got_swarm_client_revision', 'got_swarm_client_revision'),
+    ('got_swarming_client_revision', 'got_swarming_client_revision'),
+    ('got_v8_revision', 'got_v8_revision'),
+    ('got_webkit_revision', 'got_webkit_revision'),
+    ('got_webrtc_revision', 'got_webrtc_revision'),
+)
+
+
 def change_to_revision(c):
   """Handle revision == None or any invalid value."""
   try:
     return int(str(c.revision).split('@')[-1])
   except (ValueError, TypeError):
     return 0
 
 
 def updateText(section):
   # Reflect step status in text2.
@@ skipping 221 matching lines @@
   def commandComplete(self, cmd):
     """Handles status updates from buildbot slave when the step is done.
 
     Update the relevant got_XX_revision build properties if available.
     """
     source.Source.commandComplete(self, cmd)
     primary_repo = self.args.get('primary_repo', '')
     primary_revision_key = 'got_' + primary_repo + 'revision'
     properties = (
       ('got_revision', primary_revision_key),
-      ('got_nacl_revision', 'got_nacl_revision'),
-      ('got_swarm_client_revision', 'got_swarm_client_revision'),
-      ('got_swarming_client_revision', 'got_swarming_client_revision'),
-      ('got_v8_revision', 'got_v8_revision'),
-      ('got_webkit_revision', 'got_webkit_revision'),
-      ('got_webrtc_revision', 'got_webrtc_revision'),
-    )
+    ) + GOT_REVISION_PROPERTIES
     for prop_name, cmd_arg in properties:
       if cmd_arg in cmd.updates:
         got_revision = cmd.updates[cmd_arg][-1]
         if got_revision:
           self.setProperty(prop_name, str(got_revision), 'Source')
 
 
 class ApplyIssue(LoggingBuildStep):
   """Runs the apply_issue.py script on the slave."""
 
   def __init__(self, root, issue, patchset, email, password, workdir, timeout,
                server, **kwargs):
     LoggingBuildStep.__init__(self, **kwargs)
     self.args = {'root': root,
                  'issue': issue,
                  'patchset': patchset,
                  'email': email,
                  'password': password,
                  'workdir': workdir,
                  'timeout': timeout,
                  'server': server,
                  }
 
   def start(self):
     args = dict((name, self.build.render(value))
                 for name, value in self.args.iteritems())
     cmd = buildstep.LoggedRemoteCommand('apply_issue', args)
     self.startCommand(cmd)
 
+  def commandComplete(self, cmd):

[ghost stip (do not use), 2013/11/14 22:25:40]

nope

+    """Handles status updates from buildbot slave when the step is done.
+
+    Update the relevant got_XX_revision build properties if available. This only
+    happens if the DEPS file was modified.
+    """
+    LoggingBuildStep.commandComplete(self, cmd)
+    for prop_name, cmd_arg in GOT_REVISION_PROPERTIES:
+      if cmd_arg in cmd.updates:
+        got_revision = cmd.updates[cmd_arg][-1]
+        if got_revision:
+          self.setProperty(prop_name, str(got_revision), 'Source')
+
 
 class BuilderStatus(object):
   # Order in asceding severity.
   BUILD_STATUS_ORDERING = [
       builder.SUCCESS,
       builder.WARNINGS,
       builder.FAILURE,
       builder.EXCEPTION,
   ]
 
@@ skipping 798 matching lines @@
   def evaluateCommand(self, cmd):
     observer_result = self.script_observer.annotate_status
     # Check if ProcessLogShellStep detected a failure or warning also.
     log_processor_result = ProcessLogShellStep.evaluateCommand(self, cmd)
     return BuilderStatus.combine(observer_result, log_processor_result)
 
   def commandComplete(self, cmd):
     self.script_observer.handleReturnCode(cmd.rc)
     self._removePreamble()
     return ProcessLogShellStep.commandComplete(self, cmd)