Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1451)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 706313002: DevTools: draw load/first paint marks as tall vertical delimiters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
index 53f7af700db588ed72d7b5c59f8135410d5e85cb..9760f3692f6ff360878024fff16f12f3d4b3b7fe 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js
@@ -341,6 +341,24 @@ WebInspector.TracingTimelineUIUtils.isMarkerEvent = function(event)
/**
* @param {!WebInspector.TracingModel.Event} event
+ * @return {boolean}
+ */
+WebInspector.TracingTimelineUIUtils.isTallMarkerEvent = function(event)
+{
+ var recordTypes = WebInspector.TracingTimelineModel.RecordType;
+ switch (event.name) {
caseq 2014/11/07 17:39:40 return event.name !== recordTypes.TimeStamp for cl
yurys 2014/11/07 19:55:40 Done.
+ case recordTypes.MarkFirstPaint:
+ return true;
+ case recordTypes.MarkDOMContent:
+ case recordTypes.MarkLoad:
+ return event.args["data"]["isMainFrame"];
+ default:
+ return false;
+ }
+}
+
+/**
+ * @param {!WebInspector.TracingModel.Event} event
* @param {!WebInspector.Linkifier} linkifier
* @return {?Node}
*/

Powered by Google App Engine
This is Rietveld 408576698