DevTools: draw load/first paint marks as tall vertical delimiters

Source/devtools/front_end/components/FlameChart.js

Index: Source/devtools/front_end/components/FlameChart.js
diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js
index 42637d929c50adde4bc15073d3f64c945ea50812..1f3caa6966c6b1381a2e3f7c0c4cffa5e3487a23 100644
--- a/Source/devtools/front_end/components/FlameChart.js
+++ b/Source/devtools/front_end/components/FlameChart.js
@@ -156,6 +156,12 @@ WebInspector.FlameChartDataProvider.prototype = {
     markerTitle: function(index) { },
 
     /**
+     * @param {number} index
+     * @return {boolean}
+     */
+    isTallMarker: function(index) { },

[caseq, 2014/11/07 17:39:40]

nit: I wonder if we should generalize this to markerType?

[yurys, 2014/11/07 19:55:39]

I don't see other types at the moment so there is no rush and current method
looks more clear. We can always refactor this.

+
+    /**
      * @return {number}
      */
     minimumBoundary: function() { },
@@ -1038,6 +1044,18 @@ WebInspector.FlameChart.prototype = {
             context.moveTo(position, 0);
             context.lineTo(position, height);
             context.stroke();
+            if (this._dataProvider.isTallMarker(i)) {
+                context.save()
+                context.lineWidth = 1;

[caseq, 2014/11/07 17:39:40]

Is this supposed to have effect?

[yurys, 2014/11/07 19:55:39]

Yes, because outer context scope sets line width to 2.

[caseq, 2014/11/07 20:00:37]

You have "context.lineWidth = 0.5;" below.

[yurys, 2014/11/07 20:02:56]

Oh, I see, it should be just lineWidth = 1 and translate(0.5, 0.5). Thanks!

+                context.translate(0.5, 0.5);
+                context.beginPath();
+                context.moveTo(position, height);
+                context.lineWidth = 0.5;
+                context.setLineDash([10, 5]);
+                context.lineTo(position, this._canvas.height);
+                context.stroke();
+                context.restore();
+            }
         }
         context.restore();
     },