Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 706313002: DevTools: draw load/first paint marks as tall vertical delimiters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 9a5a6170499ba276bf60792851ff67e8e30aadcd..2faa97c5c0c2a1c3bf81c68dba36c312932eadc9 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -156,6 +156,17 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
return WebInspector.TracingTimelineUIUtils.eventTitle(event, this._model);
},
+ /**
+ * @override
+ * @param {number} index
+ * @return {boolean}
+ */
+ isTallMarker: function(index)
+ {
+ var event = this._markerEvents[index];
+ return WebInspector.TracingTimelineUIUtils.isTallMarkerEvent(event);
+ },
+
reset: function()
{
this._timelineData = null;

Powered by Google App Engine
This is Rietveld 408576698