Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 705513002: Subzero: Delete szdiff.py tests and ERRORS tests. (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth
Modified:
6 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Delete szdiff.py tests and ERRORS tests. Also deletes a few entirely trivial test files. These tests were useful in the early days of Subzero, but now mostly just clutter things up. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=43e948264ca7b243ad7f074c01aa7c2d7679f634

Patch Set 1 #

Patch Set 2 : Remove some trivial tests #

Total comments: 2

Patch Set 3 : Remove call.ll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -501 lines) Patch
D pydir/szdiff.py View 1 chunk +0 lines, -97 lines 0 comments Download
M tests_lit/assembler/x86/immediate_encodings.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/assembler/x86/jump_encodings.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/assembler/x86/opcode_register_encodings.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/lit.cfg View 1 chunk +0 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/8bit.pnacl.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/address-mode-opt.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/align-spill-locations.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith-opt.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/arithmetic-chain.ll View 1 1 chunk +0 lines, -28 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/bool-opt.ll View 1 2 chunks +1 line, -15 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-simple.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/call.ll View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/casts.ll View 1 1 chunk +0 lines, -16 lines 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/div_legalization.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/empty-func.ll View 1 1 chunk +0 lines, -16 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpcall.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/global.ll View 1 1 chunk +0 lines, -20 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/icmp-simple.ll View 1 1 chunk +0 lines, -20 lines 0 comments Download
M tests_lit/llvm2ice_tests/load.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/phi.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/return-int-arg.ll View 1 1 chunk +0 lines, -22 lines 0 comments Download
M tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/sdiv.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/store.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/struct-arith.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/switch-opt.ll View 2 chunks +0 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/test_i1.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 2 chunks +0 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-fcmp.ll View 2 chunks +0 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-icmp.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-select.ll View 2 chunks +0 lines, -5 lines 0 comments Download
M tests_lit/reader_tests/globalinit.pnacl.ll View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 1 month ago (2014-11-04 06:38:09 UTC) #2
jvoung (off chromium)
otherwise LGTM -- thanks! https://codereview.chromium.org/705513002/diff/20001/tests_lit/llvm2ice_tests/call.ll File tests_lit/llvm2ice_tests/call.ll (right): https://codereview.chromium.org/705513002/diff/20001/tests_lit/llvm2ice_tests/call.ll#newcode2 tests_lit/llvm2ice_tests/call.ll:2: ; currently only verify the ...
6 years, 1 month ago (2014-11-04 18:00:55 UTC) #3
Jim Stichnoth
Committed patchset #3 (id:40001) manually as 43e948264ca7b243ad7f074c01aa7c2d7679f634 (presubmit successful).
6 years, 1 month ago (2014-11-04 18:08:57 UTC) #4
Jim Stichnoth
6 years, 1 month ago (2014-11-04 18:09:40 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/705513002/diff/20001/tests_lit/llvm2ice_tests...
File tests_lit/llvm2ice_tests/call.ll (right):

https://codereview.chromium.org/705513002/diff/20001/tests_lit/llvm2ice_tests...
tests_lit/llvm2ice_tests/call.ll:2: ; currently only verify the function labels.
On 2014/11/04 18:00:55, jvoung wrote:
> Hmm, this one doesn't seem to be checking for much.
> 
> I think either remove this or add more checks?

Good point.  Removing the test.

Powered by Google App Engine
This is Rietveld 408576698